[vlc-devel] [PATCH v2] Sort tar file list

[Steve Lhomme]

Is the "ustar" format guaranteed to work all the time ?
Maybe you can split in two parts and add this extra flag separately ?

On 2019-10-04 13:30, Bernhard M. Wiedemann wrote:
> if available (in GNU tar >= 1.28)
> and use ustar format to not have pax headers add nondetermistic bits
> to make skins2/default.vlt reproducible.
> 
> See https://reproducible-builds.org/ for why this is good.
> 
> This patch was done while working on reproducible builds for openSUSE.
> 
> Signed-off-by: Bernhard M. Wiedemann <bwiedemann at suse.de>
> ---
>   share/Makefile.am | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/share/Makefile.am b/share/Makefile.am
> index e5b801a5be..327d36a64d 100644
> --- a/share/Makefile.am
> +++ b/share/Makefile.am
> @@ -92,8 +92,11 @@ skins2_default_vlt_FILES = \
>   skins2/default.vlt: $(skins2_default_vlt_FILES)
>   	$(AM_V_at)mkdir -p skins2
>   	$(AM_V_at)rm -f -- skins2/default.vlt.tmp
> -	$(AM_V_GEN)GZIP=--no-name \
> +	$(AM_V_GEN)tarsort= ; \
> +	tar --help|grep -q sort=ORDER && tarsort=--sort=name ; \
> +	GZIP=--no-name \
>   	tar cvvzf skins2/default.vlt.tmp \
> +		--format=ustar $$tarsort \
>   		--owner=root --group=root --directory="$(srcdir)/skins2" \
>   		default/
>   	$(AM_V_at)mv -f -- skins2/default.vlt.tmp skins2/default.vlt
> -- 
> 2.16.4
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>