[vlc-devel] [PATCH 2/3] egl: allow window provider to prevent eglTerminate in vlc_gl_t

Rémi Denis-Courmont remi at remlab.net
Fri Oct 4 22:23:37 CEST 2019

Le torstaina 26. syyskuuta 2019, 12.04.40 EEST Alexandre Janniaux a écrit :
> If a window provider is using EGL with the same display, the EGL state
> should be terminated from there instead of from the vlc_gl_t provider.

I don't think so.

If there is an existing EGL display on the WL display, or if the existence of 
an EGL display is unknown or non-constant, then the plugin needs to request 
reference counting. But eglTerminate() still has to be called.

Really, it's more that if AND ONLY IF it is known there is no EGL display, 
then creating a non-reference-counted EGL display is acceptable, because we 
can safely assume that eglTerminate() will drop the one and only reference.


More information about the vlc-devel mailing list