[vlc-devel] [PATCH] configure: caca conflicts with OpenGL (fixes #20543)

Alexandre Janniaux ajanni at videolabs.io
Tue Oct 8 08:36:15 CEST 2019


On Mon, Oct 07, 2019 at 09:11:18PM +0300, Rémi Denis-Courmont wrote:
> Le maanantaina 7. lokakuuta 2019, 20.03.30 EEST Alexandre Janniaux a écrit :
> > I don't really feel at ease at the idea that we just disable
> > the plugin and say the issue is fixed. This is lacking
> > context as there is no trace or core dumps on the ticket and
> > is not really a fix for this ticket but a workaround.
>
> Sure. That much the bug report already states. I can replace fixes with closes
> in the comment.

I'm not sure we would like to remove caca definitively, so
maybe keep the ticket open ?

> > If it is preventing you from integrating some code, or if
> > there are huge complaints about this, it might be better
> > to follow the same maintenance pattern as skins2,
>
> I don't know what you mean by that. The skin engine is not disabled.
>
> The skin engine does not support Wayland and MacOS but I don't get the
> comparison with the bug at hand.

It was disabled, and it was explained on the mailing list
before Erwan fixes the code. I was talking about this very
maintenance scheme.

Please check
```
[main] 376d2b561115aea7fbf233be2170db7f46687948 - commit 1750 of 82808       2%
commit 376d2b561115aea7fbf233be2170db7f46687948
Refs: 4.0.0-dev-7765-g376d2b56111
Author:     Thomas Guillem <thomas at gllm.fr>
AuthorDate: Tue Apr 16 09:00:23 2019 +0200
Commit:     Thomas Guillem <thomas at gllm.fr>
CommitDate: Fri May 10 09:43:21 2019 +0200

    configure: disable skins2

    It need to be ported to the new player, playlist and tree.
```

and the related revert:

```
commit 656fb0768857d906813df4f5347c005cb931e9b4
Refs: 4.0.0-dev-8617-g656fb076885
Author:     Erwan Tulou <erwan10 at videolan.org>
AuthorDate: Sat Jun 29 15:29:36 2019 +0200
Commit:     Erwan Tulou <erwan10 at videolan.org>
CommitDate: Sat Jul 6 18:49:55 2019 +0200

    Revert "configure: disable skins2"

    This reverts commit 376d2b561115aea7fbf233be2170db7f46687948.
```

What I meant is that if it is a blocking issue, you can
probably disable it until someone maintains and fix it.

But as I can't really reproduce, it doesn't seem like it
is coming from VLC but from your distribution packages or
your build instead maybe. I'll try to investigate when I
find some time to unblock you.


Regards,
--
Alexandre Janniaux
Videolabs


More information about the vlc-devel mailing list