[vlc-devel] [PATCH 2/2] contrib: caca: disable ncurses on Linux

[Thomas Guillem]

OK, so this commit is fine, I'll test on macos.

OK for this set.
With my additional 2 patches, I'm able to build and use caca from contribs.

On Wed, Oct 9, 2019, at 09:07, Steve Lhomme wrote:
> On 2019-10-09 8:41, Thomas Guillem wrote:
> > Why not disabling it for all OSes ? Do we depend on ncurses ?
> 
> There's this in the code:
> 
> #ifdef __APPLE__
>      // Make sure we don't try to open a window.
>      driver = "ncurses";
> #endif
> 
> 
> > On Tue, Oct 8, 2019, at 19:36, Rémi Denis-Courmont wrote:
> >> It does not compile.
> >> ---
> >>   contrib/src/caca/rules.mak | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/contrib/src/caca/rules.mak b/contrib/src/caca/rules.mak
> >> index 4bce456217..d27a356830 100644
> >> --- a/contrib/src/caca/rules.mak
> >> +++ b/contrib/src/caca/rules.mak
> >> @@ -41,6 +41,9 @@ endif
> >>   ifdef HAVE_WIN32
> >>   CACA_CONF += --disable-ncurses
> >>   endif
> >> +ifdef HAVE_LINUX
> >> +CACA_CONF += --disable-ncurses
> >> +endif
> >>   
> >>   .caca: caca
> >>   	$(RECONF)
> >> -- 
> >> 2.23.0
> >>
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel