[vlc-devel] [PATCH 2/4] prefetch: Don't activate for preparse

[Thomas Guillem]

On Wed, Oct 9, 2019, at 10:15, Steve Lhomme wrote:
> On 2019-10-09 9:21, Thomas Guillem wrote:
> > 
> > 
> > On Tue, Oct 8, 2019, at 19:41, Rémi Denis-Courmont wrote:
> >> I disagree.
> >>
> >> This will cause very very small reads, and potentially seeks backward - all
> >> ending in ridiculously bad performance.
> > 
> > How so ? If prefetch is disabled, then the "cache" stream filter will be used.
> > 
> > cf. in src/input/access.c:
> > s = stream_FilterChainNew(s, "prefetch,cache");
> 
> So maybe the patch should be done in stream_AccessNew() which has a 
> preparsing parameter and only load the cache filter in the 
> stream_FilterChain.

+1

> 
> > 
> >>
> >> -- 
> >> Реми Дёни-Курмон
> >> http://www.remlab.net/
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel