[vlc-devel] [PATCH 2/4] prefetch: Don't activate for preparse

[Rémi Denis-Courmont]

Exactly that's horribly slow on slow networks, that was the whole point of adding prefetch. Prefetch can handle blocking streams and cache non-blocking streams.

And again, there's more to preparsing than taglib anyway.

Le 9 octobre 2019 12:46:55 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>It is faster when using taglib that could search for the ID3tag at
>different offsets, the STREAM_CACHE_TRACK 3 helps a lot.
>
>On Wed, Oct 9, 2019, at 11:39, Thomas Guillem wrote:
>> 
>> On Wed, Oct 9, 2019, at 11:36, Rémi Denis-Courmont wrote:
>>> Then this change is plain dumb. Cache is terrible on slow networks.
>> 
>> I tested it and concluded it was faster than no cache. Could you
>elaborate ? I don't understand.
>> 
>>> 
>>> Le 9 octobre 2019 10:21:24 GMT+03:00, Thomas Guillem
><thomas at gllm.fr> a écrit :
>>>> 
>>>> 
>>>> On Tue, Oct 8, 2019, at 19:41, Rémi Denis-Courmont wrote:
>>>>> I disagree.
>>>>> 
>>>>> This will cause very very small reads, and potentially seeks
>backward - all 
>>>>> ending in ridiculously bad performance.
>>>> 
>>>> How so ? If prefetch is disabled, then the "cache" stream filter
>will be used.
>>>> 
>>>> cf. in src/input/access.c: 
>>>> s = stream_FilterChainNew(s, "prefetch,cache");
>>>> 
>>>> 
>>>> > 
>>>>> -- 
>>>>> Реми Дёни-Курмон
>>>>> http://www.remlab.net/vlc-devel mailing list
>>>>> To unsubscribe or modify your subscription options:
>>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>> 
>>> -- 
>>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté. 
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191009/7cacc131/attachment.html>