[vlc-devel] [PATCH 1/7] video_output: document what display_lock really locks

[Thomas Guillem]

Hi,

On Wed, Oct 9, 2019, at 17:36, Steve Lhomme wrote:
> ---
>  src/video_output/vout_internal.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/video_output/vout_internal.h b/src/video_output/vout_internal.h
> index 29f2144f82b..73ad01612bc 100644
> --- a/src/video_output/vout_internal.h
> +++ b/src/video_output/vout_internal.h
> @@ -177,6 +177,8 @@ struct vout_thread_sys_t
>      /* Video output display */
>      vout_display_cfg_t display_cfg;
>      vout_display_t *display;
> +    // protect access to display between the vout thread and the
> +    // DecoderThread/ModuleThreads, may be locked while window_lock is locke

You should not mention decoder.c here, the vout might be used from something in the future

Nit: use the same comment style than the file 

>      vlc_mutex_t     display_lock;
>  
>      picture_pool_t  *private_pool;
> -- 
> 2.17.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel