[vlc-devel] [PATCH] medialib: fix genre->tracks call parameters

Hugo Beauzée-Luyssen hugo at beauzee.fr
Wed Oct 9 18:58:29 CEST 2019


On Wed, Oct 9, 2019, at 6:54 PM, Alexandre Janniaux wrote:
> QueryParameters were silently casted into bool.
> ---
>  modules/misc/medialibrary/medialib.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/misc/medialibrary/medialib.cpp 
> b/modules/misc/medialibrary/medialib.cpp
> index cdbf5e39a7a..b7e0166ab14 100644
> --- a/modules/misc/medialibrary/medialib.cpp
> +++ b/modules/misc/medialibrary/medialib.cpp
> @@ -1427,7 +1427,7 @@ int MediaLibrary::listGenre( int listQuery, const 
> medialibrary::QueryParameters*
>              if ( pattern != nullptr )
>                  query = genre->searchTracks( pattern, paramsPtr );
>              else
> -                query = genre->tracks( paramsPtr );
> +                query = genre->tracks( false, paramsPtr );
>              if ( query == nullptr )
>                  return VLC_EGENERIC;
>              switch ( listQuery )

LGTM, thanks for spotting this!

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the vlc-devel mailing list