[vlc-devel] [PATCH 7/7] vout: display: pass the vout_display_priv_t directly in internal calls

[Rémi Denis-Courmont]

And I disagree with the other patch too, so...

This is totally against common practices for doing OOP-like code in non-OOP languages like C. You can't even do that sort of change in OOP...

Le 10 octobre 2019 09:15:00 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2019-10-09 18:19, Rémi Denis-Courmont wrote:
>> Hi,
>> 
>> This feels very backward. We don't normally pass the private data.
>And the
>> compilers are perfectly capable to optimize the back-and-forth
>conversion so
>> the change is completely useless.
>
>container_of() is a glorified cast. One should not use cast unless 
>there's no other option.
>
>This is exactly the same as was done in 
>`a46508d9dd8eeccc8e8fa778b331f6c027db84c7`.
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191010/056df116/attachment.html>