[vlc-devel] [PATCH 4/9] video_output: no need to check if there's a display to Stop in vout_Close

[Thomas Guillem]

On Thu, Oct 10, 2019, at 16:26, Steve Lhomme wrote:
> The window still needs to be disabled when the vout is closed.
> ---
>  src/video_output/video_output.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
> index a16a8ec621c..7dad8278db7 100644
> --- a/src/video_output/video_output.c
> +++ b/src/video_output/video_output.c
> @@ -1759,8 +1759,7 @@ void vout_Close(vout_thread_t *vout)
>      vout_thread_sys_t *sys = vout->p;
>      assert(!sys->dummy);
>  
> -    if (sys->display != NULL)
> -        vout_Stop(vout);
> +    vout_Stop(vout);

This allowed to remove an extra lock/unlock of the window_lock.

>  
>      vout_IntfDeinit(VLC_OBJECT(vout));
>      vout_snapshot_End(sys->snapshot);
> -- 
> 2.17.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel