[vlc-devel] [PATCH 09/48] video_output: pass the video format to vout_SizeWindow()

Rémi Denis-Courmont remi at remlab.net
Sat Oct 12 14:52:40 CEST 2019

Le lauantaina 12. lokakuuta 2019, 14.42.49 EEST Rémi Denis-Courmont a écrit :
> Le perjantaina 11. lokakuuta 2019, 16.33.23 EEST Steve Lhomme a écrit :
> > This will be needed when the GetDevice call will create a window without
> > setting the sys->original which is only related to the display module.
> This is wrong as pointed out in previous iteration.

Well it's not so much wrong as bizarre. We  cannot enable a window without a 
size, so we need an original format to enable the window. Ditto whenever we 
force a resize due to user changing A/R, crop or zoom.

And I don't see how the original format used to compute the ideal size of the 
window can differ from the current video ES format. AFAICT they are either the 
same, or the vout display does not exist, and we can use original to store the 
window sizing format.


More information about the vlc-devel mailing list