[vlc-devel] [PATCH 1/4] libvlc: Add "fullscreen-monitor" setting

[Thomas Guillem]

On Sun, Oct 13, 2019, at 16:22, Gabriel Luci wrote:
> I assume you mean because the output plugin doesn't necessarily have a window? So isn't this the same as all the "Window properties" settings, which are defined in the same place? Or would you prefer to see this under that "Window properties" section too?

This option is a string for windows, but it could be an integer on other OSes
Rémi would prefer to have this option in win32/window.c

vlc_module_begin()
 set_shortname(N_("Win32 window"))
 set_description(N_("Win32 window"))
 set_category(CAT_VIDEO)
 set_subcategory(SUBCAT_VIDEO_VOUT)
 set_capability("vout window", 10)
 set_callback(Open)
vlc_module_end()

But I'm not sure about it, on Linux, this id would be something like "0:0", so a string too.
Personally, I prefer to have a global settings for all OSses (and maybe do some integer conversion on some implementations).

> 
> On Sun, Oct 13, 2019 at 3:18 AM Rémi Denis-Courmont <remi at remlab.net> wrote:
>> Le sunnuntaina 13. lokakuuta 2019, 6.58.28 EEST Gabriel Luci a écrit :
>> > This will contain the name of the display device to always show
>> > fullscreen video on.
>> > ---
>> > src/libvlc-module.c | 6 ++++++
>> > 1 file changed, 6 insertions(+)
>> > 
>> > diff --git a/src/libvlc-module.c b/src/libvlc-module.c
>> > index d3da4e5fb8..163e4deda0 100644
>> > --- a/src/libvlc-module.c
>> > +++ b/src/libvlc-module.c
>> > @@ -314,6 +314,11 @@ static const char *const ppsz_align_descriptions[] =
>> > #define FULLSCREEN_LONGTEXT N_( \
>> > "Start video in fullscreen mode" )
>> > 
>> > +#define FULLSCREEN_MONITOR_TEXT N_("Display device for fullscreen video")
>> > +#define FULLSCREEN_MONITOR_LONGTEXT N_( \
>> > + "In a multiple monitor configuration, you can specify the device name "
>> > \ + "of the display that you want the fullscreen video window to open
>> > on." ) +
>> > #define VIDEO_ON_TOP_TEXT N_("Always on top")
>> > #define VIDEO_ON_TOP_LONGTEXT N_( \
>> > "Always place the video window on top of other windows." )
>> > @@ -1641,6 +1646,7 @@ vlc_module_begin ()
>> > add_bool( "fullscreen", false, FULLSCREEN_TEXT, FULLSCREEN_LONGTEXT,
>> > false ) change_short('f')
>> > change_safe ()
>> > + add_string( "fullscreen-monitor", "", FULLSCREEN_MONITOR_TEXT,
>> > FULLSCREEN_MONITOR_LONGTEXT, false ) add_bool( "embedded-video", 1,
>> > EMBEDDED_TEXT, EMBEDDED_LONGTEXT, true )
>> > add_bool( "xlib", true, "", "", true )
>> 
>> The values depend on the output plugin, so thus does not belong as a global 
>> setting, just like the audio output device.
>> 
>> -- 
>> レミ・デニ-クールモン
>> http://www.remlab.net/
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191014/2911881f/attachment.html>