[vlc-devel] [PATCH] taglib: Enable caching on the IOStream

[Rémi Denis-Courmont]

Hi,

Using cache only essentially optimises for half-assed plugins that don't implement streaming like the libsmbclient-based one, but *breaks* slow bandwidth inputs even with properly implemented plugins like HTTP or FTP, which require prefetch.

I don't think we should optimise for bugs if it means breaking something else.

Le 10 octobre 2019 16:54:59 GMT+03:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>We can't use vlc_stream_NewURL as it will include the skiptags filter
>---
> modules/meta_engine/taglib.cpp | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/modules/meta_engine/taglib.cpp
>b/modules/meta_engine/taglib.cpp
>index c71a66ca58..2826a7d85c 100644
>--- a/modules/meta_engine/taglib.cpp
>+++ b/modules/meta_engine/taglib.cpp
>@@ -842,6 +842,9 @@ static int ReadMeta( vlc_object_t* p_this)
>     free( psz_uri );
>     if( p_stream == NULL )
>         return VLC_EGENERIC;
>+    stream_t* p_filter = vlc_stream_FilterNew( p_stream, "cache" );
>+    if( p_filter )
>+        p_stream = p_filter;
> 
>     VlcIostream s( p_stream );
>     f = FileRef( &s );
>-- 
>2.20.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191014/4e87dfe5/attachment.html>