[vlc-devel] [PATCH 2/4] vout: Use "fullscreen-monitor" setting

[Rémi Denis-Courmont]

Hi,

I never questioned the data type, did I? Point was that this can't be a core setting since the value, and especially the enumeration callback for possible values, depends on the window provider plugin.

Le 15 octobre 2019 10:09:11 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>"fullscreen output nul-terminated identifier,"
>
>That looks like an id for the screen, like Gabriel is using.
>
>On Tue, Oct 15, 2019, at 08:53, Rémi Denis-Courmont wrote:
>> By window manager I mean what is commonly called window manager in
>the context of GUI.
>> 
>> And the ID parameter is the same as in the owner callbacks, which are
>documented.
>> 
>> Le 13 octobre 2019 17:15:29 GMT+03:00, Gabriel Luci <github at luci.ca>
>a écrit :
>>> By window manager, do you mean at vout_ChangeFullscreen
>(src\video_output\video_output.c:390)? That's where it starts passing a
>handle to the window rather than the vout.
>>> 
>>> What was that id parameter originally intended for? I noticed it was
>changed from a bool to a char* by you last year, but never used.
>>> 
>>> On Sun, Oct 13, 2019 at 3:18 AM Rémi Denis-Courmont
><remi at remlab.net> wrote:
>>>> Le sunnuntaina 13. lokakuuta 2019, 6.58.29 EEST Gabriel Luci a
>écrit :
>>>>  > Pass the setting as the id parameter to vout_ChangeFullscreen()
>>>>  > ---
>>>>  > src/video_output/vout_intf.c | 6 +++++-
>>>>  > 1 file changed, 5 insertions(+), 1 deletion(-)
>>>>  > 
>>>>  > diff --git a/src/video_output/vout_intf.c
>b/src/video_output/vout_intf.c
>>>>  > index ce50616fc9..9a0120fb4d 100644
>>>>  > --- a/src/video_output/vout_intf.c
>>>>  > +++ b/src/video_output/vout_intf.c
>>>>  > @@ -566,7 +566,11 @@ static int FullscreenCallback( vlc_object_t
>*p_this,
>>>>  > char const *psz_cmd, (void)psz_cmd; (void) oldval; (void)p_data;
>>>>  > 
>>>>  > if( newval.b_bool )
>>>>  > - vout_ChangeFullscreen(p_vout, NULL);
>>>>  > + {
>>>>  > + char *psz_fullscreen_monitor = var_InheritString( p_vout,
>>>>  > "fullscreen-monitor" ); + vout_ChangeFullscreen(p_vout,
>>>>  > psz_fullscreen_monitor);
>>>>  > + free( psz_fullscreen_monitor );
>>>>  > + }
>>>>  > else
>>>>  > vout_ChangeWindowed(p_vout);
>>>>  > return VLC_SUCCESS;
>>>> 
>>>>  This breaks the API definition and intended semantics of passing
>NULL there - 
>>>>  let the window manager pick the most suitable default.
>>>> 
>>>>  -- 
>>>>  雷米‧德尼-库尔蒙
>>>> http://www.remlab.net/
>>>> 
>>>> 
>>>> 
>>>>  _______________________________________________
>>>>  vlc-devel mailing list
>>>>  To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté. 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191015/0b277eef/attachment.html>