[vlc-devel] [PATCH 3/6] clock: add vlc_clock_SetDecoderLatency

[Rémi Denis-Courmont]

Hi,

The problem is that this does not fix the bug. It just fixes it if your computer is slow enough not to trigger the fallback mode 

So sure, insofar as the fallback mode exists, it won't "break". But it also won't fix the bug - just like it won't fix it for dynamic ES.

Le 15 octobre 2019 17:09:59 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Thu, Oct 10, 2019, at 10:00, Francois Cartegnie wrote:
>> Le 10/10/2019 à 09:16, Thomas Guillem a écrit :
>> 
>> > 
>> > We already have to explain to users that they can't read low fps
>(<15fps) video because their computer is too powerful.
>> > 
>> < 30fps here
>
>After more tests, I'm quite confident that this actual branch is
>needed. No being able to play a 25fps video because you have too much
>core is mandatory to fix for VLC 4.0.
>
>Rémi, could you share some example / usecase where this patch set can
>be problematic ?
>- I don't know how to test multithread input (capture device)
>- for inputs with dynamic ES (TS, RTP): this patch could not do any
>worse. In case of dynamic ES, the latency won't be changed (if the
>video track is loaded some time after the audio).
>
>> 
>> -- 
>> Francois Cartegnie
>> VideoLAN - VLC Developer
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191015/f46dd974/attachment.html>