[vlc-devel] [PATCH] smb: try libdsm first

[Rémi Denis-Courmont]

Le keskiviikkona 16. lokakuuta 2019, 21.24.17 EEST Alexandre Janniaux a écrit 
:
> I'm not qualified for the security issue, but the additional
> roundtrip issue seems irrelevant to me as the main usage of
> SMBv1 for VLC is through NAS server that are on a local
> network.

In theory, yes. In practice, the reality is that YMMV.

There are plenty of angry reports of bad VLC performance with SMB, and AFAICT 
it's pretty much always down to slow networking.

> > Fixing a patch is out of scope of a code review.
> 
>  While it's not cleary written that you MUST,
> the common sense and usual review skills on most open
> source project would agree that it's a pivotal points for
> having sane code review.

The main point of the code review is to maintain or improve code quality (and 
that's not just my opinion, it's paraphrasing Wikipedia).

If you have the luxury to have the paid time to supplement the pure review 
part with help and suggestions, good for you. I don't, and I don't foresee a 
change in this respect any time soon. And in my moral values, it is not 
appropriate of a commercial developer to ask this of a hobbyist.

But if you want a solution: do what Microsoft advises and don't use SMB1.

-- 
Rémi Denis-Courmont
http://www.remlab.net/