[vlc-devel] [PATCH 1/4] libvlc: Add "fullscreen-monitor" setting

Rémi Denis-Courmont remi at remlab.net
Wed Oct 16 21:11:33 CEST 2019


Le keskiviikkona 16. lokakuuta 2019, 21.46.26 EEST Alexandre Janniaux a écrit 
:
> Hi,
> 
> Sorry if this wasn't clear in the previous post.
> 
> I mean, you're making review on an UX patch (vlc-variable and usage in Qt),
> so it seems sensical to me that it has to match the expected UX.

It's not a UX patch. This specific patch out of the series is touching the 
core, in a way that contradicts the existing Wayland code (XDG-shell), the 
reference model (i.e. audio output device) and the agreed upon design of the 
affected feature.

> My arguments are on the previous-previous post, but the TL;DR is: how the
> interface can determine what configuration variable to set in the general
> way ?

Just like audio output devices. Also did I mention it's just like audio output 
devices?

-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list