[vlc-devel] [PATCH 1/4] libvlc: Add "fullscreen-monitor" setting

[Rémi Denis-Courmont]

Le keskiviikkona 16. lokakuuta 2019, 22.27.30 EEST Alexandre Janniaux a écrit 
:
> On Wed, Oct 16, 2019 at 10:11:33PM +0300, Rémi Denis-Courmont wrote:
> > Le keskiviikkona 16. lokakuuta 2019, 21.46.26 EEST Alexandre Janniaux a
> > écrit
> > 
> > It's not a UX patch. This specific patch out of the series is touching the
> > core, in a way that contradicts the existing Wayland code (XDG-shell), the
> > reference model (i.e. audio output device) and the agreed upon design of
> > the affected feature.
> 
> It adds a parameter that the user can directly provide, I
> hardly see how this can be closer to UX.

No it does not. As already noted, there are no ways to implement that 
parameter correctly in the core. The parameter should and already does exist 
in the window provider, where we can have enumeration callbacks and address 
any (other) platform-specific aspect.

> > Just like audio output devices. Also did I mention it's just like audio
> > output devices?
> 
> I brought examples on why it wasn't compatible, because you
> don't select the fullscreen device from a menu during the
> playback

Uh, I don't know how your player does it. But VLC has a fullscreen option in 
the video menu. And FWIW, the system menu on my WM (KWin) has a "send to 
screen" list which contains exactly the list of monitors, not at all unlike 
the list of audio output devices in VLC.

I certainly would not want to have to type in the identifier of the monitor in 
the VLC preferences - which is what this patch proposes.

> and the underlying audio multiplexer already has
> the correct preference most of the time,

Based on what metric?

Most audio HALs only have a system-wide default. Only MMDevice and PulseAudio 
track the device preference per session.

> while the video compositor usually doesn't

[Citation needed]

Some window managers remember which application was on which output. Some 
don't. But most if not all have a default output. Indeed, VLC has relied on 
the notion of default output for 20 years.

> and you set the setting for the most of the time usage.

Same as audio output.

> You didn't bring any argument against this,

Oh really?

"The values depend on the output plugin,"

"this can't be a core setting since the value, and especially the enumeration 
callback for possible values, depends on the window provider plugin"

"This specific patch (...) contradicts the existing Wayland code (XDG-shell)"

Meanwhile, you did not explain how a core setting is going to work. You can't 
seriously be suggesting that users type in the monitor identifier in the VLC 
preferences... so much for being "compatible with a correct UX".

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/