[vlc-devel] [PATCH] smb: try libdsm first

Thomas Guillem thomas at gllm.fr
Wed Oct 16 22:06:53 CEST 2019

It escalated quickly because I used the wrong word, I'm verry sorry for that. Just for you know, vlabs would never push such a bad hack if it was only for a custumer.

I asked advices from Simon, my boss, because he knows a lot more about security than me and I needed different point of views since this patch is quite dangerous. 

Now, I'll work on implementing the proper solution, that is asking the user to force smb1. 

On Wed, Oct 16, 2019, at 21:16, Alexandre Janniaux wrote:
> > The main point of the code review is to maintain or improve code quality (and
> > that's not just my opinion, it's paraphrasing Wikipedia).
> Words have few meaning in humain relations, intents have.
> > If you have the luxury to have the paid time to supplement the pure review
> > part with help and suggestions, good for you. I don't, and I don't foresee a
> > change in this respect any time soon. And in my moral values, it is not
> > appropriate of a commercial developer to ask this of a hobbyist.
> I'm sorry, but I think I've spend a huge amount of time
> collecting precise information for some of your reviews,
> and proving hints with huge details on how to implement
> some aspects or how things were working, sometime even
> just quoting the documentation for OpenGL or building
> complete scenario and examples for windowing.
> While this was pretty interesting and in destination of the
> mailing list more than just you, almost all of this work was
> done on **my free time** (aka, sometimes 2:00 AM), because
> you didn't want another competent developer to do the review
> instead. So I would kindly ask you to not consider my time
> to not be less important than your if you want to keep by
> this logic.
> And really, I don't want to force you to do anything. You
> are completely free to do anything and I have no interest
> nor power to change anything of that. I even appreciate
> your involvement on a lot of subjects and the good
> feedbacks you can provide from your expertise.
> But if you don't have time or don't want to provide a
> constructive feedback on public places for some subjects,
> you should probably consider rework your agenda to focus on
> your hobby, your health, your whatever your priority is
> instead of loosing time posting incomplete or rought
> reviews because you don't want to manage the time for this.
> I'm practicing this a lot and it eventually improved my
> whole development practice and IRL time, and I find it a
> lot saner to practice demanding hobby like working on VLC.
> Again, I can't and don't want to constraint you, but your
> arguments would probably be easier to consider when some
> care would be taken to bring them here, and I'm sure it
> will save you time for a real and productive VLC activity.
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> > But if you want a solution: do what Microsoft advises and don't use SMB1.
> >
> > --
> > RĂ©mi Denis-Courmont
> > http://www.remlab.net/
> >
> >
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list