[vlc-devel] [PATCH 1/2] input: reduce controls from input_ControlPush

[Thomas Guillem]

Seek controls are already dropped, I don't really see what my patch is changing.

Could you elaborate please ?

On Thu, Oct 17, 2019, at 09:39, Rémi Denis-Courmont wrote:
> Hi,
> 
> Yet it looks to me that your patch does exactly that; I share François' concern here.
> 
> I proposed reducing seek-like controls earlier, but the algorithm was different, specifically to avoid that issue.
> 
> Le 17 octobre 2019 10:29:54 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>> Hello,
>> 
>> On Wed, Oct 16, 2019, at 14:37, Francois Cartegnie wrote:
>>> Le 16/10/2019 à 12:58, Thomas Guillem a écrit :
>>>> It could fix some SEEK controls that are dropped in some rare cases:
>>>>  - The input_thread is taking too long to demux/process a seek
>>>>  - The UI is spamming SEEK controls (but it should be paced a minimum)
>>> I don't see how dropping controls can't introduce inconsistencies.
>> 
>> I never said that.
>> 
>> > 
>>> Seek value is related to program, for example.
>>> 
>>> -- 
>>> Francois Cartegnie
>>> VideoLAN - VLC Developervlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191017/e8c59b02/attachment.html>