[vlc-devel] [PATCH 1/4] libvlc: Add "fullscreen-monitor" setting

Gabriel Luci github at luci.ca
Thu Oct 17 18:26:56 CEST 2019

My other patch uses that drop-down to populate this setting. But in the
Advanced Preferences, yeah, it shows up as a plain text box. I guess you
could argue that it is "advanced", but I wouldn't argue if you say that's
bad UX. And I understand the macOS doesn't use the Qt interface, and I have
no experience there, so I don't know if there's an equivalent drop-down box
there already.

I've been following the discussion but not commenting since I know I don't
know the code base very well. I agree that the enumerating the screens and
setting/using the value is dependent on the window provider, but my
rationale was that every window provider would be able to enumerate the
screens and set and use the value. So no matter which OS you're on, it is
possible to put a value in this setting.

So Rémi, the alternative is for each window provider to have its own
setting? Was Thomas right when saying:

    have this option in win32/window.c

        set_shortname(N_("Win32 window"))
        set_description(N_("Win32 window"))
        set_capability("vout window", 10)

I'm happy to make that change. However, then I'm not sure how to use the
setting. vout_ChangeFullscreen accepts an id parameter, which is supposed
to be the "output identifier", which I assume means the ID of the monitor?
(correct me if I'm wrong) So how do we find that value when calling
vout_ChangeFullscreen if only the window provider knows? Or am I
misunderstanding something there?

On Thu, Oct 17, 2019 at 2:18 AM Steve Lhomme <robux4 at ycbcr.xyz> wrote:

> On 2019-10-16 21:58, Rémi Denis-Courmont wrote:
> > Meanwhile, you did not explain how a core setting is going to work. You
> can't
> > seriously be suggesting that users type in the monitor identifier in the
> > preferences... so much for being "compatible with a correct UX".
> There's already a setting listing the screen to use when going in
> fullscreen. You can't type it manually though.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191017/d76301a6/attachment.html>

More information about the vlc-devel mailing list