[vlc-devel] [PATCH 1/3] keystore: add a comment

[Thomas Guillem]

Comment from the 416712589f485ebd20712aa2f2ec799c2d8ded8a commit message.

Because I wanted to remove this extra check (again) forgetting why it was
needed.
---
 src/misc/keystore.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/misc/keystore.c b/src/misc/keystore.c
index 55b094350dc..73d52625bc4 100644
--- a/src/misc/keystore.c
+++ b/src/misc/keystore.c
@@ -448,6 +448,9 @@ vlc_credential_get(vlc_credential *p_credential, vlc_object_t *p_parent,
         }
 
         case GET_FROM_KEYSTORE:
+            /* Opening the keystore might trigger a user action while this is
+             * meant to be a silent operation, especially if the service we're
+             * connecting to doesn't require credentials. */
             if (!psz_dialog_title || !psz_dialog_fmt)
                 return false;
 
-- 
2.20.1