[vlc-devel] [PATCH] smb: try libdsm first

[Alexandre Janniaux]

Hi,

On Sun, Oct 20, 2019 at 01:19:21PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 17. lokakuuta 2019, 9.48.59 EEST Steve Lhomme a écrit :
> > On 2019-10-16 20:49, Rémi Denis-Courmont wrote:
> > > Le keskiviikkona 16. lokakuuta 2019, 21.24.17 EEST Alexandre Janniaux a
> > > écrit>
> > >> I'm not qualified for the security issue, but the additional
> > >> roundtrip issue seems irrelevant to me as the main usage of
> > >> SMBv1 for VLC is through NAS server that are on a local
> > >> network.
> > >
> > > In theory, yes. In practice, the reality is that YMMV.
> >
> > (side note: CWSWTOATY)
> > (Can We Stop With The Obscure Acronyms Thank You)
>
> That's not an obscrue acronym.
>
> Can you test your changes properly before you push them, like you don't get an
> obvious use-after-free or double-free on end of video, thank you.

You meant to post on the push work, it's unrelated to the
libdsm module patch right ?

Regards,
--
Alexandre Janniaux
Videolabs