[vlc-devel] [PATCH 1/4] opengl/vdpau: rename DecoderContextXXX to DecoderDeviceXXX

Thomas Guillem thomas at gllm.fr
Mon Oct 21 10:22:36 CEST 2019


This patch set is fixing #23006

LGTM for the patch set.

On Mon, Oct 21, 2019, at 09:53, Thomas Guillem wrote:
> OK
> 
> On Mon, Oct 21, 2019, at 08:45, Steve Lhomme wrote:
> > The callbacks are related to the decoder device, not the video context.
> > ---
> >  modules/video_output/opengl/converter_vdpau.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/modules/video_output/opengl/converter_vdpau.c 
> > b/modules/video_output/opengl/converter_vdpau.c
> > index 06596a490bb..5220699128f 100644
> > --- a/modules/video_output/opengl/converter_vdpau.c
> > +++ b/modules/video_output/opengl/converter_vdpau.c
> > @@ -194,17 +194,17 @@ Open(vlc_object_t *obj)
> >  }
> >  
> >  static void
> > -DecoderContextClose(vlc_decoder_device *device)
> > +DecoderDeviceClose(vlc_decoder_device *device)
> >  {
> >      vdp_release_x11(device->opaque);
> >  }
> >  
> >  static const struct vlc_decoder_device_operations dev_ops = {
> > -    .close = DecoderContextClose,
> > +    .close = DecoderDeviceClose,
> >  };
> >  
> >  static int
> > -DecoderContextOpen(vlc_decoder_device *device, vout_window_t *window)
> > +DecoderDeviceOpen(vlc_decoder_device *device, vout_window_t *window)
> >  {
> >      if (!window || !vlc_xlib_init(VLC_OBJECT(window)))
> >          return VLC_EGENERIC;
> > @@ -229,5 +229,5 @@ vlc_module_begin ()
> >      set_subcategory(SUBCAT_VIDEO_VOUT)
> >      add_shortcut("vdpau")
> >      add_submodule()
> > -        set_callback_dec_device(DecoderContextOpen, 3)
> > +        set_callback_dec_device(DecoderDeviceOpen, 3)
> >  vlc_module_end ()
> > -- 
> > 2.17.1
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list