[vlc-devel] [PATCH 2/9] avcodec: vdpau: allocate output pictures locally

[Steve Lhomme]

Also I overlooked the code when I did this patch. The RGB format I 
picked for the pool is wrong, I should one of VLC_CODEC_VDPAU_VIDEO_420, 
VLC_CODEC_VDPAU_VIDEO_422 or VLC_CODEC_VDPAU_VIDEO_444.

On 2019-10-21 15:46, Steve Lhomme wrote:
> Indeed, I was missing some patches in this branch where the pool would 
> actually be used.
> 
> On 2019-10-19 14:52, Rémi Denis-Courmont wrote:
>> Le perjantaina 18. lokakuuta 2019, 18.11.07 EEST Steve Lhomme a écrit :
>>> The pictures are similar to the ones created in the OpenGL converter.
>>>
>>> !! There might be a lifecycle issue when releasing the decoder module 
>>> and
>>> pictures are still "in-flight". We will need to keep the module and pool
>>> alive as long as pictures are alive, or keep the resources allocated 
>>> tied
>>> to the video context so they are released together.
>>
>> This does not look right. The pushed output surfaces are already 
>> allocated by
>> the mixer since 77a80f40db4609b3ce7c12651680b755ff8d6680. They don't 
>> belong in
>> the decoder, which has no use for output surfaces.
>>
>> -- 
>> レミ・デニ-クールモン
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel