[vlc-devel] [PATCH v3 2/2] CI: Add GitLab CI

Steve Lhomme robux4 at ycbcr.xyz
Wed Oct 23 07:00:31 CEST 2019


On 2019-10-22 18:03, Hugo Beauzée-Luyssen wrote:
>> +#
>> +# Debian continuous
>> +#
>> +debian:
>> +    extends: .continuous-common
>> +    image:
>> +        name: $VLC_DEBIAN_IMAGE
>> +    script: |
>> +        export NCPU=$(getconf _NPROCESSORS_ONLN)
>> +        cd extras/tools && ./bootstrap && make -j$NCPU -k\
> 
> I'm not a big fan of make -k || make -j1 to detect errors. This might waste a lost of CPU depending on what contrib fails.
> I agree that it's harder to see what failed, but I'd rather waste my time looking for an error than to make all other jobs wait for a doomed task to complete.

To save time looking for errors we can use `--output-sync=recurse`.
I also agree there isn't much point for the CI to find all the errors. 
Especially given the number of targets we have to build, it's better to 
fail quickly.

In this case it's the tools, so not sure it's a major issue.

> However, if other people prefer to keep it that way, then let's keep it
> 


More information about the vlc-devel mailing list