[vlc-devel] [PATCH 1/4] libvlc: Add "fullscreen-monitor" setting

[Gabriel Luci]

Following up on this: am I correct in my understanding that those are our
only 2 options?

On Thu, Oct 17, 2019 at 5:26 PM Gabriel Luci <github at luci.ca> wrote:

> I do understand the difference between the two, but they are dependent on
> each other, no?
>
> From my inexperienced perspective, I see two options:
>
> 1. Use a global setting, read it in FullscreenCallback(), and pass it to
> vout_ChangeFullscreen() (which is what I did in this patchset)
> or,
> 2. Define the setting in the window provider plugin, but then that means
> (correct me if I'm wrong) the window provider plugin also has the job of
> reading that setting in its SetFullscreen function. But then (I think) that
> means that there is no purpose for the id parameter in
> vout_ChangeFullscreen(), vout_window_SetFullScreen(), and the window
> provider SetFullscreen functions.
>
> That's why I went with option 1, because I saw the id parameter there
> doing nothing, so I figured that's what it was supposed to be for, which
> led me to believe a global setting was the only way to go.
>
> On Thu, Oct 17, 2019 at 3:44 PM Rémi Denis-Courmont <remi at remlab.net>
> wrote:
>
>> Le torstaina 17. lokakuuta 2019, 19.26.56 EEST Gabriel Luci a écrit :
>> > I'm happy to make that change. However, then I'm not sure how to use the
>> > setting. vout_ChangeFullscreen accepts an id parameter, which is
>> supposed
>> > to be the "output identifier", which I assume means the ID of the
>> monitor?
>> > (correct me if I'm wrong) So how do we find that value when calling
>> > vout_ChangeFullscreen if only the window provider knows? Or am I
>> > misunderstanding something there?
>>
>> I think you're mixing up two things here - changing the fullscreen output
>> used
>> by an active window which uses vout_ChangeFullscreen(), versus changing
>> the
>> default fullscreen output for future windows which uses window provider-
>> dependent mechanism - a setting in Qt and XDG-shell cases.
>>
>> --
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191024/671a855d/attachment.html>