[vlc-devel] [PATCH 1/4] libvlc: Add "fullscreen-monitor" setting
remi at remlab.net
Thu Oct 24 21:33:42 CEST 2019
Le torstaina 24. lokakuuta 2019, 18.39.02 EEST Gabriel Luci a écrit :
> I think you misunderstood my question. This entire patchset was about
> setting it in the preferences before playback starts. There should be one
> *setting*, yes. But, from what I see, there are two ways to implement it.
> (That's what I meant by "2 options")
> In this patch, I defined a global setting in src/libvlc-module.c. Rémi
> objected to that approach and said the setting should be defined in the
> window manager (I assume that means in win32/window.c). But if it's defined
> there, the setting should be *read* in win32/window.c too.
I've never written that it should be in the window manager. That makes no
sense. It has to be in the window provider, which is the only component that
knows how to enumerate outputs. I've already explained at least three times in
this thread why it cannot be in the core.
> My objection to that is that Rémi himself had added an "id" parameter to
> the vout_ChangeFullscreen() last year, which currently is always NULL.
Because the UI does not use it yet. Feel free to fix that.
> That seems to be the place to pass the ID of the monitor to put the
> fullscreen window on.
That's kind of the whole point, yes.
> If I'm correct on that, then the setting needs to be read in
> src/video_output/vout_intf.c and thus it should be a global setting.
WTF? How do you handle enumeration with a global setting? How do you handle
different windowing systems in a global setting? How do you not break the
existing XDG-shell implementation?
More information about the vlc-devel