[vlc-devel] [PATCH 1/3] display: turn the reset_pictures flag into a simple boolean

Steve Lhomme robux4 at ycbcr.xyz
Fri Oct 25 07:36:39 CEST 2019

On 2019-10-24 20:40, Rémi Denis-Courmont wrote:
> Le torstaina 24. lokakuuta 2019, 18.18.58 EEST Steve Lhomme a écrit :
>> It is already read alongside control calls which are protected by the
>> caller.
> But it is written potentially asynchronously by a vout display thread. I don't
> really care but I don't see the point in making the code more brittle here.

My point is that there doesn't need to be an extra layer of protection 
other than the one already provided. It's even set in the vout thread 
loop, rather than in other threads like the controls (window thread and 
GUI thread for callback variables). In the end we may even handle it in 
the vout loop without waiting for a control to appear.

More information about the vlc-devel mailing list