[vlc-devel] [PATCH 1/2] decoder device: allow modules to create a decoder device

[Steve Lhomme]

On 2019-10-25 14:33, Rémi Denis-Courmont wrote:
> Don't remove the used qualifier. And this won't work anyway because sout 
> does not have, and should not need a window. This needs a different 
> function.

My bad, I overlooked the other issue with a NULL window. The decoder 
device is a VLC object that needs a parent, which can't be NULL.
This is worked in my work branch but not here.

Forget about this patch for now.

> Le 25 octobre 2019 15:31:06 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a 
> écrit :
> 
>     Like the transcoder or the mosaic bridge.
>     ------------------------------------------------------------------------
>       include/vlc_codec.h | 2 +-
>       src/libvlccore.sym  | 1 +
>       2 files changed, 2 insertions(+), 1 deletion(-)
> 
>     diff --git a/include/vlc_codec.h b/include/vlc_codec.h
>     index 6649ef94cc2..c51d4eba1a7 100644
>     --- a/include/vlc_codec.h
>     +++ b/include/vlc_codec.h
>     @@ -604,7 +604,7 @@ typedef int (*vlc_decoder_device_Open)(vlc_decoder_device *device,
>        * This function will be hidden in the future. It is now used by opengl vout
>        * module as a transition.
>        */
>     -VLC_USED vlc_decoder_device *
>     +VLC_API vlc_decoder_device *
>       vlc_decoder_device_Create(vout_window_t *window);
>       
>       /**
>     diff --git a/src/libvlccore.sym b/src/libvlccore.sym
>     index d1a048be988..ce18e3ad6b6 100644
>     --- a/src/libvlccore.sym
>     +++ b/src/libvlccore.sym
>     @@ -83,6 +83,7 @@ decoder_AbortPictures
>       decoder_NewAudioBuffer
>       decoder_UpdateVideoFormat
>       decoder_UpdateVideoOutput
>     +vlc_decoder_device_Create
>       vlc_decoder_device_Hold
>       vlc_decoder_device_Release
>       demux_PacketizerDestroy
> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>