[vlc-devel] [PATCH] vaapi: add typedefs for OES_EGL_image extension

Thomas Guillem thomas at gllm.fr
Mon Oct 28 09:17:16 CET 2019


LGTM

On Sun, Oct 27, 2019, at 15:55, Alexandre Janniaux wrote:
> Hi,
> 
> Ping for the patch,
> 
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> 
> On Mon, Oct 21, 2019 at 11:39:15PM +0200, Alexandre Janniaux wrote:
> > OES_EGL_image extension is an OpenGL ES extension and the typedef might
> > not be available on EGL or OpenGL extension headers.
> >
> > As of October 19 2019, it makes compilation fail on my ArchLinux
> > because they are not defined anymore in the headers included.
> > ---
> >  modules/video_output/opengl/converter_vaapi.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/modules/video_output/opengl/converter_vaapi.c b/modules/video_output/opengl/converter_vaapi.c
> > index 36e3e974ec..95b754c4af 100644
> > --- a/modules/video_output/opengl/converter_vaapi.c
> > +++ b/modules/video_output/opengl/converter_vaapi.c
> > @@ -35,6 +35,15 @@
> >  #include "converter.h"
> >  #include "../../hw/vaapi/vlc_vaapi.h"
> >
> > +/* From https://www.khronos.org/registry/OpenGL/extensions/OES/OES_EGL_image.txt
> > + * The extension is an OpenGL ES extension but can (and usually is) available on
> > + * OpenGL implementations. */
> > +#ifndef GL_OES_EGL_image
> > +#define GL_OES_EGL_image 1
> > +typedef void *GLeglImageOES;
> > +typedef void (*PFNGLEGLIMAGETARGETTEXTURE2DOESPROC)(GLenum target, GLeglImageOES image);
> > +#endif
> > +
> >  struct priv
> >  {
> >      VADisplay vadpy;
> > --
> > 2.23.0
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list