[vlc-devel] [PATCH 07/18] decoder: remove redundant chroma fix in FixDisplayFormat

Steve Lhomme robux4 at ycbcr.xyz
Mon Oct 28 13:41:24 CET 2019


It's redundant when FixDisplayFormat is called from the update_format callback.

When called from CreateVoutIfNeeded in the get_device callback, the chroma of
the source format doesn't change the decoder device creation. The value is
likely not even set during that call anyway.
---
 src/input/decoder.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/input/decoder.c b/src/input/decoder.c
index c9802b9a007..8f04bd61545 100644
--- a/src/input/decoder.c
+++ b/src/input/decoder.c
@@ -405,7 +405,6 @@ static int ModuleThread_UpdateAudioFormat( decoder_t *p_dec )
 static void FixDisplayFormat(decoder_t *p_dec, video_format_t *fmt)
 {
     *fmt = p_dec->fmt_out.video;
-    fmt->i_chroma = p_dec->fmt_out.i_codec;
 
     if( vlc_fourcc_IsYUV( fmt->i_chroma ) )
     {
-- 
2.17.1



More information about the vlc-devel mailing list