[vlc-devel] [PATCH] mosaic_bridge: don't use inline for callbacks

[Rémi Denis-Courmont]

Ok because inline is useless in this case (and I prefer static inline over inline static) but I don't see a problem here?

Le 28 octobre 2019 13:08:06 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>---
> modules/stream_out/mosaic_bridge.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/modules/stream_out/mosaic_bridge.c
>b/modules/stream_out/mosaic_bridge.c
>index a7ee45edc9a..3624ce794f8 100644
>--- a/modules/stream_out/mosaic_bridge.c
>+++ b/modules/stream_out/mosaic_bridge.c
>@@ -84,8 +84,8 @@ static void  Del( sout_stream_t *, void * );
> static int   Send( sout_stream_t *, void *, block_t * );
> 
> static void decoder_queue_video( decoder_t *p_dec, picture_t *p_pic );
>-inline static int video_update_format_decoder( decoder_t *p_dec,
>vlc_video_context * );
>-inline static picture_t *video_new_buffer_filter( filter_t * );
>+static int video_update_format_decoder( decoder_t *p_dec,
>vlc_video_context * );
>+static picture_t *video_new_buffer_filter( filter_t * );
> static void video_update_format( video_format_t *, es_format_t * );
> 
> static int HeightCallback( vlc_object_t *, char const *,
>@@ -572,7 +572,7 @@ static int Send( sout_stream_t *p_stream, void *id,
>block_t *p_buffer )
>     return ret == VLCDEC_SUCCESS ? VLC_SUCCESS : VLC_EGENERIC;
> }
> 
>-inline static int video_update_format_decoder( decoder_t *p_dec,
>vlc_video_context *vctx )
>+static int video_update_format_decoder( decoder_t *p_dec,
>vlc_video_context *vctx )
> {
>     struct decoder_owner *p_owner = dec_get_owner( p_dec );
>     video_update_format( &p_owner->video, &p_dec->fmt_out );
>@@ -598,7 +598,7 @@ inline static int video_update_format_decoder(
>decoder_t *p_dec, vlc_video_conte
>     return 0;
> }
> 
>-inline static picture_t *video_new_buffer_filter( filter_t *p_filter )
>+static picture_t *video_new_buffer_filter( filter_t *p_filter )
> {
>     return picture_NewFromFormat( &p_filter->fmt_out.video );
> }
>-- 
>2.17.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191028/612c2fd3/attachment.html>