[vlc-devel] [PATCH] darwin/thread: Ignore vlc_mutex_unlock failures

[Marvin Scholz]

On 29 Oct 2019, at 12:39, Rémi Denis-Courmont wrote:

> Yeah and I would really appreciate if TC members did their job and 
> considered the implications and alternatives of a patch instead of 
> support blindly removing assertions and singling out another TC member 
> for actually doing his job.
>

Ok, would you be so kind to provide ideas how to fix this then, as it 
sounds like
you have an idea how to do it? I don’t know how we can fix this inside 
of VLC,
like I already said in my last mail.

What happens in reality and for several years now is the same as with 
the patch, we
just ignore this error by not enabling debug builds on macOS, which of 
course might
miss a lot of other important assertions.
So this patch does not change anything about real-world behavior, it 
just means macOS
developers are finally able to run debug enabled builds again.

> Le 29 octobre 2019 12:49:53 GMT+02:00, "Hugo Beauzée-Luyssen" 
> <hugo at beauzee.fr> a écrit :
>> On Tue, Oct 29, 2019, at 11:39 AM, Rémi Denis-Courmont wrote:
>>> How do you even know that a crash report is related to this issue?
>> What
>>> I see is that this patch makes two assumptions,neither of them are
>>> documented nor backed in any way. But sure send it to the TC.
>>> Obviously, you will provide explanations what the assumptions
>>> underlying this patch are, how they are verified, and why no proper
>>> workaround can be made instead, so that the TC can make an informed
>>> decision, and you won't abuse your ties with Hugo to distort the
>> vote,
>>> hmm...
>>>
>>
>> I would *really* appreciate that you'd refrain from this kind of
>> implications.
>>
>> -- 
>>  Hugo Beauzée-Luyssen
>>  hugo at beauzee.fr
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
> excuser ma brièveté._______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel