[vlc-devel] [PATCH] darwin/thread: Ignore vlc_mutex_unlock failures

[Thomas Guillem]

On Tue, Oct 29, 2019, at 13:20, Rémi Denis-Courmont wrote:
> There are many potential alternatives of varying complexity and applicability, the most obvious (but neither least complex, nor most generic) being what we already do on some other platforms.

OK, so there is a potential fix we could work on, based on Windows thread cancellation handler.
It's a shame to talk about this potential fix only now in this discussion. It could have avoided some irritation from everyone.

The fix is not trivial at all and will impact the core of macOS thread handling.

I honestly ask myself the following now: is it worth it to implement the windows thread cancelation handler in macOS for a bug that could have 0 impacts. Indeed, it had always been there (since more than 7 years) without any visible impact from us or the user.

It's a honest question, not trolling at all. And I would like hearing from you what we should do now.

If you decide to implement the thread cancellation from Windows, I volunteer myself to work on it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191029/1e9aebfd/attachment.html>