[vlc-devel] [PATCH] share: add desktop files to open BR/DVD/CDA/VCD

[Thomas Guillem]

Finally merged, thanks !

On Tue, Oct 29, 2019, at 18:40, Mathieu Velten wrote:
> Hi Nicolas,
> 
> It uses the bluray:// (or else) uri scheme instead of file://. It's been a while and I don't have my bluray player on me to double check but last time I checked with file:// it was going through all the files in the disc folder without managing to open anything.
> 
> Regards,
> 
> Mathieu
> 
> 
> Le mar. 29 oct. 2019 à 17:30, Nicolas Chauvet <kwizart at gmail.com> a écrit :
>> Hello Mathieu,
>> 
>> I don't quite understand why each "legacy media" need to be spitted into a dedicated desktop file to be opened by vlc ?
>> Seems like to be needed with older Desktop Environments. (vlc has dedicated ones for kde4 already).
>> At least, Gnome opens disks as appropriate with me. Is there any case where it doesn't work already ?
>> 
>> Thx
>> 
>> Le mar. 29 oct. 2019 à 10:50, Mathieu Velten <matmaul at gmail.com> a écrit :
>>> Up ? I know it's boring but it should be quick 🙂
>>> 
>>> This has been reviewed already been reviewed a while ago :
>>> https://patches.videolan.org/patch/19474/
>>> 
>>> 
>>> Regards,
>>> 
>>> Mathieu
>>> 
>>> Le jeu. 17 oct. 2019 à 00:56, Mathieu Velten <matmaul at gmail.com> a écrit :
>>>> ---
>>>>  share/Makefile.am | 5 +++--
>>>>  share/vlc-openbd.desktop.in | 9 +++++++++
>>>>  share/vlc-opencda.desktop.in | 9 +++++++++
>>>>  share/vlc-opendvd.desktop.in | 9 +++++++++
>>>>  share/vlc-openvcd.desktop.in | 9 +++++++++
>>>>  share/vlc.desktop.mimetypes | 4 ----
>>>>  6 files changed, 39 insertions(+), 6 deletions(-)
>>>>  create mode 100644 share/vlc-openbd.desktop.in
>>>>  create mode 100644 share/vlc-opencda.desktop.in
>>>>  create mode 100644 share/vlc-opendvd.desktop.in
>>>>  create mode 100644 share/vlc-openvcd.desktop.in
>>>> 
>>>> diff --git a/share/Makefile.am b/share/Makefile.am
>>>> index 6d8cd9dc2f..bbfb2efe3c 100644
>>>> --- a/share/Makefile.am
>>>> +++ b/share/Makefile.am
>>>> @@ -5,7 +5,7 @@ EXTRA_DIST =
>>>>  desktopdir = $(datadir)/applications
>>>>  if !HAVE_WIN32
>>>>  if !HAVE_DARWIN
>>>> -desktop_DATA = vlc.desktop
>>>> +desktop_DATA = vlc.desktop vlc-openbd.desktop vlc-opendvd.desktop vlc-openvcd.desktop vlc-opencda.desktop
>>>>  appdatadir = $(datarootdir)/metainfo
>>>>  appdata_DATA = $(appdata_in_files:.xml.in=.xml)
>>>>  appdata_in_files = vlc.appdata.xml.in
>>>> @@ -13,9 +13,10 @@ endif
>>>>  endif
>>>> 
>>>>  EXTRA_DIST += vlc.desktop.in vlc.desktop.mimetypes
>>>> +EXTRA_DIST += vlc-openbd.desktop.in vlc-opendvd.desktop.in vlc-openvcd.desktop.in vlc-opencda.desktop.in
>>>>  CLEANFILES += $(desktop_DATA) $(appdata_DATA)
>>>> 
>>>> -vlc.desktop: vlc.desktop.in $(top_builddir)/config.status
>>>> +%.desktop: %.desktop.in $(top_builddir)/config.status
>>>>  $(AM_V_GEN)mimetypes="$$(sed 's/\s*#.*$$//g' $(srcdir)/vlc.desktop.mimetypes | egrep -v '^$$' | tr "\n" ';')"; \
>>>>  sed \
>>>>  -e 's,\@bindir\@,$(bindir),g' \
>>>> diff --git a/share/vlc-openbd.desktop.in b/share/vlc-openbd.desktop.in
>>>> new file mode 100644
>>>> index 0000000000..386eb20215
>>>> --- /dev/null
>>>> +++ b/share/vlc-openbd.desktop.in
>>>> @@ -0,0 +1,9 @@
>>>> +[Desktop Entry]
>>>> +Version=1.0
>>>> +Name=VLC media player (Blu-ray)
>>>> +NoDisplay=true
>>>> +Exec=@bindir@/vlc --started-from-file bluray://%f
>>>> +Icon=vlc
>>>> +Terminal=false
>>>> +Type=Application
>>>> +MimeType=x-content/video-bluray
>>>> diff --git a/share/vlc-opencda.desktop.in b/share/vlc-opencda.desktop.in
>>>> new file mode 100644
>>>> index 0000000000..503d5a85f4
>>>> --- /dev/null
>>>> +++ b/share/vlc-opencda.desktop.in
>>>> @@ -0,0 +1,9 @@
>>>> +[Desktop Entry]
>>>> +Version=1.0
>>>> +Name=VLC media player (Audio CD)
>>>> +NoDisplay=true
>>>> +Exec=@bindir@/vlc --started-from-file cdda://%f
>>>> +Icon=vlc
>>>> +Terminal=false
>>>> +Type=Application
>>>> +MimeType=x-content/audio-cdda
>>>> diff --git a/share/vlc-opendvd.desktop.in b/share/vlc-opendvd.desktop.in
>>>> new file mode 100644
>>>> index 0000000000..aadc44a672
>>>> --- /dev/null
>>>> +++ b/share/vlc-opendvd.desktop.in
>>>> @@ -0,0 +1,9 @@
>>>> +[Desktop Entry]
>>>> +Version=1.0
>>>> +Name=VLC media player (DVD)
>>>> +NoDisplay=true
>>>> +Exec=@bindir@/vlc --started-from-file dvd://%f
>>>> +Icon=vlc
>>>> +Terminal=false
>>>> +Type=Application
>>>> +MimeType=x-content/video-dvd
>>>> diff --git a/share/vlc-openvcd.desktop.in b/share/vlc-openvcd.desktop.in
>>>> new file mode 100644
>>>> index 0000000000..c6dd894e83
>>>> --- /dev/null
>>>> +++ b/share/vlc-openvcd.desktop.in
>>>> @@ -0,0 +1,9 @@
>>>> +[Desktop Entry]
>>>> +Version=1.0
>>>> +Name=VLC media player (VCD)
>>>> +NoDisplay=true
>>>> +Exec=@bindir@/vlc --started-from-file vcd://%f
>>>> +Icon=vlc
>>>> +Terminal=false
>>>> +Type=Application
>>>> +MimeType=x-content/video-vcd;x-content/video-svcd
>>>> diff --git a/share/vlc.desktop.mimetypes b/share/vlc.desktop.mimetypes
>>>> index 0d866f7da8..d521c6c34f 100644
>>>> --- a/share/vlc.desktop.mimetypes
>>>> +++ b/share/vlc.desktop.mimetypes
>>>> @@ -119,10 +119,6 @@ x-scheme-handler/icyx # Icecast
>>>> 
>>>>  # Linux desktop environment hooks for ISOs etc.
>>>>  application/x-cd-image
>>>> -x-content/video-vcd
>>>> -x-content/video-svcd
>>>> -x-content/video-dvd
>>>> -x-content/audio-cdda
>>>>  x-content/audio-player
>>>> 
>>>>  # Playlists / text/xml list with URLs
>>>> -- 
>>>> 2.21.0
>>>> 
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> 
>> -- 
>> -
>> Nicolas (kwizart)
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191031/2dd456a1/attachment-0001.html>