[vlc-devel] [PATCH 0/3] Add microdns services advertisement (V2)

Roland Bewick roland.bewick at gmail.com
Mon Sep 2 07:25:40 CEST 2019

Changes since V1:
- Changed add_string to add_module_list with NULL default value and improved configuraion variable names (SA_* to SERVICE_ADVERTISEMENT_*)
- Merged submodule stub commit with the implementation
- Dropped IP detection commits (We get the unicast interface IP from libmicrodns now rather than having to guess in the VLC submodule)
- Removed http-host override for setting IP address in A/AAAA record
- Merged VLC service announcement object and libvlc commits 
- Added vlc_ prefix to services announcement object functions
- Removed useless allocations of discovery_sys / advertisement_sys in microdns.c and changed to use a union instead.
- Advertisement now defaults to using IPv6. IPv4 can be used with --services-advertisement-address-family v4

Not changed:
- _vlc._tcp service type is hardcoded
- Module is activated through command line arguments

Run with /vlc --services-advertisement mdns

Note: This patch requires the libmicrodns 0.1.0 contribs update which hasn't yet merged.

Roland Bewick (3):
  Add services-advertisement configuration options
  Create services_advertisement VLC object
  Add microdns services_advertisement submodule

 include/vlc_services_advertisement.h  |  87 +++++++
 modules/services_discovery/microdns.c | 318 +++++++++++++++++++++-----
 src/Makefile.am                       |   2 +
 src/libvlc-module.c                   |  21 ++
 src/libvlc.c                          |  32 +++
 src/libvlc.h                          |   2 +
 src/misc/services_advertisement.c     |  84 +++++++
 7 files changed, 489 insertions(+), 57 deletions(-)
 create mode 100644 include/vlc_services_advertisement.h
 create mode 100644 src/misc/services_advertisement.c


More information about the vlc-devel mailing list