[vlc-devel] [PATCH 4/4] sout: add airplay support
thomas at gllm.fr
Mon Sep 2 09:43:03 CEST 2019
On Sun, Sep 1, 2019, at 12:09, Felix Paul Kühne wrote:
> Were your remarks ever addressed? This is stuck, right, and we never
> merged this?
No, and we can't merge it in the current state.
> > On 26. Nov 2018, at 18:16, Thomas Guillem <thomas at gllm.fr> wrote:
> > Hello,
> > Sorry for the late review.
> > I got of lot of warning from GCC 8.2: https://gist.github.com/tguillem/1386b927cf524fba22b55b01ce8833fc
> > I got a SEGFAULT when trying to run airplay: https://gist.github.com/tguillem/e67af5b00e25aac1ef39642be006a126
> > I guess that vlc_getaddrinfo() is returning an error (and you forgot to check it).
> > Same for the calloc return that is not checked. By the way, a calloc for NI_MAXNUMERICHOST seems overkill. Since the NI_MAXNUMERICHOST value (64) is small and constant, you could allocate with the stack here ("char psz_ipv4_ip[NI_MAXNUMERICHOST];")
> > It's quite hard to review your patches inline since they are attached in the mail. Do you have a github/gitlab link, that I could use for review ?
> > On Tue, Oct 9, 2018, at 18:10, Jean-Baptiste Kempf wrote:
> >> On Tue, 9 Oct 2018, at 18:58, Felix Paul Kühne wrote:
> >>> Hi Alexander,
> >>> This is AirPlay 2 only, no? If so, this should be written here and maybe
> >>> the file should even be renamed in case we add support for AirPlay 1 aka
> >>> RAOP, too.
> >> AirPlay 1 is not RAOP.
> >> RAOP is audio-only.
> >> --
> >> Jean-Baptiste Kempf - President
> >> +33 672 704 734
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel