[vlc-devel] [PATCH 2/2] notify: replace deprecated gdk_pixbuf_unref

Thomas Guillem thomas at gllm.fr
Mon Sep 2 09:50:48 CEST 2019


set merged, thanks!

On Sat, Aug 31, 2019, at 10:16, Alexandre Janniaux wrote:
> From [1]:
> > gdk_pixbuf_unref has been deprecated since version 2.0 and should
> > not be used in newly-written code.
> >
> > Use g_object_unref().
> 
> [1]: 
> https://developer.gnome.org/gdk-pixbuf/stable/gdk-pixbuf-Reference-Counting-and-Memory-Mangement.html#gdk-pixbuf-unref
> ---
>  modules/notify/notify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/notify/notify.c b/modules/notify/notify.c
> index 1bab4350af..b3f52123b6 100644
> --- a/modules/notify/notify.c
> +++ b/modules/notify/notify.c
> @@ -345,7 +345,7 @@ static int Notify( vlc_object_t *p_this, const char 
> *psz_temp, GdkPixbuf *pix,
>      if( pix )
>      {
>          notify_notification_set_icon_from_pixbuf( notification, pix );
> -        gdk_pixbuf_unref( pix );
> +        g_object_unref( pix );
>      }
> 
>      /* Adds previous and next buttons in the notification if actions 
> are supported. */
> --
> 2.20.1
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list