[vlc-devel] [PATCH 09/13] decoder: remove always true boolean

[Steve Lhomme]

The VLC_TICK_INVALID check is done early. After that we don't need to check it
anymore.
---
 src/input/decoder.c | 22 ++++------------------
 1 file changed, 4 insertions(+), 18 deletions(-)

diff --git a/src/input/decoder.c b/src/input/decoder.c
index c81f23c236..f82e608ad4 100644
--- a/src/input/decoder.c
+++ b/src/input/decoder.c
@@ -1025,8 +1025,6 @@ static int DecoderPlayVideo_internal( struct decoder_owner *p_owner, picture_t *
         p_picture->b_force = true;
     }
 
-    const bool b_dated = p_picture->date != VLC_TICK_INVALID;
-
     vlc_mutex_unlock( &p_owner->lock );
 
     /* FIXME: The *input* FIFO should not be locked here. This will not work
@@ -1040,24 +1038,12 @@ static int DecoderPlayVideo_internal( struct decoder_owner *p_owner, picture_t *
     if( p_vout == NULL )
         goto discard;
 
-    if( p_picture->b_force || p_picture->date != VLC_TICK_INVALID )
-        /* FIXME: VLC_TICK_INVALID -- verify video_output */
+    if( p_picture->b_still )
     {
-        if( p_picture->b_still )
-        {
-            /* Ensure no earlier higher pts breaks still state */
-            vout_Flush( p_vout, p_picture->date );
-        }
-        vout_PutPicture( p_vout, p_picture );
-    }
-    else
-    {
-        if( b_dated )
-            msg_Warn( p_dec, "early picture skipped" );
-        else
-            msg_Warn( p_dec, "non-dated video buffer received" );
-        goto discard;
+        /* Ensure no earlier higher pts breaks still state */
+        vout_Flush( p_vout, p_picture->date );
     }
+    vout_PutPicture( p_vout, p_picture );
 
     return VLC_SUCCESS;
 discard:
-- 
2.17.1