[vlc-devel] [PATCH 1/3] Add services-advertisement configuration options

[Rémi Denis-Courmont]

Le maanantaina 2. syyskuuta 2019, 8.25.41 EEST Roland Bewick a écrit :
> --services-advertisement=mdns
> --services-advertisement-address-family={v4,v6}
> ---
>  src/libvlc-module.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> index f5de78bcae..76e5287b8d 100644
> --- a/src/libvlc-module.c
> +++ b/src/libvlc-module.c
> @@ -1232,6 +1232,21 @@ static const char *const psz_recursive_list_text[] =
> { "Specifies the services discovery modules to preload, separated by " \
> "colons. Typical value is \"sap\"." )
> 
> +static const char *const psz_address_family_list[] = {
> +    "v4", "v6" };
> +static const char *const psz_address_family_list_text[] = {
> +    N_("IPv4"), N_("IPv6") };

This is not right. Dual-stack is a thing. And we already have flags for this, 
no need to add new ones. And this really ought to be automatic anyway.

-- 
Rémi Denis-Courmont
http://www.remlab.net/