[vlc-devel] [PATCH 3/3] Add microdns services_advertisement submodule
Jean-Baptiste Kempf
jb at videolan.org
Wed Sep 4 09:32:44 CEST 2019
On Tue, Sep 3, 2019, at 17:19, Rémi Denis-Courmont wrote:
> Le maanantaina 2. syyskuuta 2019, 19.34.58 EEST Thomas Guillem a écrit :
> > One other concern:
> >
> > SA modules should not annonce anything by default but the core should ask
> > for it.
> >
> > I propose the following changes:
> > - The sa module initialize from Open but doesn't annonce anything, it just
> > registers an annonce callback. - Add vlc_sa_annonce( libvlc, const char
> > *name, const char *type, unsigned port ), that will call the annonce
> > callback of the main SA.
>
> What makes you think a port number describe any and all types of service
> announcements? The only currently supported announce types is SDP, and that's
> definitely carrying a hell of a lot more data than a port number.
SSDP is dead, SDP is for a very different purpose than advertising our servers.
Call it vlc_sa_mdns_* or something, if you prefer...
--
Jean-Baptiste Kempf - President
+33 672 704 734
More information about the vlc-devel
mailing list