[vlc-devel] [PATCH 3/3] Add microdns services_advertisement submodule

[Thomas Guillem]

On Fri, Sep 6, 2019, at 08:49, Roland Bewick wrote:
> 
> 
> On Wed, 4 Sep 2019 at 2:32 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> On Tue, Sep 3, 2019, at 17:19, Rémi Denis-Courmont wrote:
>>  > Le maanantaina 2. syyskuuta 2019, 19.34.58 EEST Thomas Guillem a écrit :
>>  > > One other concern:
>>  > > 
>>  > > SA modules should not annonce anything by default but the core should ask
>>  > > for it.
>>  > > 
>>  > > I propose the following changes:
>>  > > - The sa module initialize from Open but doesn't annonce anything, it just
>>  > > registers an annonce callback. - Add vlc_sa_annonce( libvlc, const char
>>  > > *name, const char *type, unsigned port ), that will call the annonce
>>  > > callback of the main SA.
>>  > 
>>  > What makes you think a port number describe any and all types of service 
>>  > announcements? The only currently supported announce types is SDP, and that's 
>>  > definitely carrying a hell of a lot more data than a port number.
>> 
>>  SSDP is dead, SDP is for a very different purpose than advertising our servers.
>>  Call it vlc_sa_mdns_* or something, if you prefer...
> 
> So, the plan is to follow Thomas’ recommendations?

2 choices:
 -1/ Either VLC instance has only one sa module that can handle multiple protocol announcement
 -2/ Or the VLC instance has a list of SA, each one handling one service announcement, there can be multiple instance of the same plugin but with different parameters (for different protocols)

I prefer the choice 1/ but I'm OK with 2/ too.

I'm still waiting for Rémi answer about the choice 2/

"you need to put the set of parameters in the probe function (open), right ? Are you saying you want one module capability per protocol to handle all the different parameters ?"


> 
> Any ideas about setting up libmicrodns as dual-stack rather than passing a single IP address to listen to? Or, just advertise VLC on Ipv6 and forget about v4?
> 
>> 
>> 
>> --
>>  Jean-Baptiste Kempf - President
>>  +33 672 704 734
>>  _______________________________________________
>>  vlc-devel mailing list
>>  To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190906/22131275/attachment.html>