[vlc-devel] [PATCH 3/3] Add microdns services_advertisement submodule

Thomas Guillem thomas at gllm.fr
Mon Sep 9 08:55:05 CEST 2019

On Sat, Sep 7, 2019, at 14:41, Rémi Denis-Courmont wrote:
> Le perjantaina 6. syyskuuta 2019, 10.07.02 EEST Thomas Guillem a écrit :
> > I prefer the choice 1/ but I'm OK with 2/ too.
> > 
> > I'm still waiting for Rémi answer about the choice 2/
> I'm still waiting for an explanation how choice 1 can possibly work with more 
> than one advertisement protocol.

I said I don't care about the solution we choose, but I don't fully understand yours. No need to wait for explanation about 1/ if we choose 2.

But I can explain again about 1/

 - The main sa module is loaded (Open() callback) and does nothing
 - vlc_sa_Start(protocol) is called on the main SA module, it return an unique identifier, the called need to keep it in order to stop it in the future.

Problem: we leave the list handling to the module. Open() does nothing and can't really know if it will fail, so no real module fallback.

> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list