[vlc-devel] [PATCH] ogg: fix stringop-truncation warning
Alexandre Janniaux
ajanni at videolabs.io
Tue Sep 10 10:18:12 CEST 2019
Hi,
Small ping for the patch too,
Regards,
--
Alexandre Janniaux
Videolabs
On Thu, Sep 05, 2019 at 12:53:02PM +0200, Alexandre Janniaux wrote:
> ---
> modules/mux/ogg.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/modules/mux/ogg.c b/modules/mux/ogg.c
> index 82e5e90aa2..c03e5355b7 100644
> --- a/modules/mux/ogg.c
> +++ b/modules/mux/ogg.c
> @@ -499,10 +499,11 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
>
> memcpy( p_stream->p_oggds_header->stream_type, "audio", 5 );
>
> - memset( p_stream->p_oggds_header->sub_type, 0, 4 );
> char buf[5];
> + memset( buf, 0, sizeof(buf) );
> snprintf( buf, sizeof(buf), "%"PRIx16, i_tag );
> - strncpy( p_stream->p_oggds_header->sub_type, buf, 4 );
> +
> + memcpy( p_stream->p_oggds_header->sub_type, buf, 4 );
>
> p_stream->p_oggds_header->i_time_unit = MSFTIME_FROM_SEC(1);
> p_stream->p_oggds_header->i_default_len = 1;
> --
> 2.23.0
>
More information about the vlc-devel
mailing list