[vlc-devel] [PATCH 3/5] vout: chroma chain: fix scaling before transform

[Francois Cartegnie]

Le 12/09/2019 à 09:00, Steve Lhomme a écrit :

>> +    es_format_Copy( &fmt_mid, &p_filter->fmt_out );
>> +    /* Set mid format to same rotation as source,
>> +     * so we get proper scaling before transform */
>> +    video_format_TransformTo( &fmt_mid.video,
>> p_filter->fmt_in.video.orientation );
> 
> This is not equivalent to what EsFormatMergeSize() was doing. For
> example the fmt_in SAR was copied to the middle format. Same thing for
> the fmt_in dimensions which are not used at all here.
> 
> Expanding EsFormatMergeSize() is probably the way to go.


The transformation should have changed destination A/R, there's no raw
source or dest value to copy.

-- 
Francois Cartegnie
VideoLAN - VLC Developer