[vlc-devel] [PATCH] lib: media: fix media not being preparsed after a failure

[Thomas Guillem]

On Fri, Sep 13, 2019, at 15:03, Steve Lhomme wrote:
> On 2019-09-13 14:43, Thomas Guillem wrote:
> > After a failure (like when browsing a smb folder with credential), it was
> > impossible to repase the same media again.
> 
> Nitpicking: "reparse"

Thanks

> 
> > ---
> >   lib/media.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/media.c b/lib/media.c
> > index a1c6d4e24a..61cb82a889 100644
> > --- a/lib/media.c
> > +++ b/lib/media.c
> > @@ -282,7 +282,7 @@ static void send_parsed_changed( libvlc_media_t *p_md,
> >       }
> >   
> >       p_md->parsed_status = new_status;
> > -    if( p_md->parsed_status == libvlc_media_parsed_status_skipped )
> > +    if( p_md->parsed_status != libvlc_media_parsed_status_done )
> 
> Now that includes libvlc_media_parsed_status_timeout as well, is it what 
> we want ?

Yes, if a parse timeouted, it can works in the future  again.

> 
> >           p_md->has_asked_preparse = false;
> >   
> >       vlc_mutex_unlock( &p_md->parsed_lock );
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel