[vlc-devel] [PATCH 10/14] filters: allow the filter owner not to provide pictures

Steve Lhomme robux4 at ycbcr.xyz
Tue Sep 17 16:22:38 CEST 2019


In that case the internal allocator of the default allocator are used.
---
 include/vlc_filter.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/include/vlc_filter.h b/include/vlc_filter.h
index 0bc10e91997..6363ccf3048 100644
--- a/include/vlc_filter.h
+++ b/include/vlc_filter.h
@@ -161,11 +161,14 @@ struct filter_t
  */
 static inline picture_t *filter_NewPicture( filter_t *p_filter )
 {
-    picture_t *pic;
+    picture_t *pic = NULL;
     if ( p_filter->owner.video != NULL && p_filter->owner.video->buffer_new != NULL)
         pic = p_filter->owner.video->buffer_new( p_filter );
-    else
+    if ( pic == NULL )
+    {
+        // legacy filter owners not setting a default filter_allocator
         pic = picture_NewFromFormat( &p_filter->fmt_out.video );
+    }
     if( pic == NULL )
         msg_Warn( p_filter, "can't get output picture" );
     return pic;
-- 
2.17.1



More information about the vlc-devel mailing list