[vlc-devel] [PATCH] vout: create/release the decoder device when the window is enabled/disabled

[Steve Lhomme]

On 2019-09-19 8:11, Steve Lhomme wrote:
> On 2019-09-18 18:16, Rémi Denis-Courmont wrote:
>> Le keskiviikkona 18. syyskuuta 2019, 17.13.18 EEST Steve Lhomme a écrit :
>>> The decoder device ("dec-dev") should be tied to the lifecyle of the 
>>> window.
>>
>> Well, no. It's tied to an enabled window, which is longer than a vout, 
>> but
>> shorter than a window.
> 
> I can change it to:
> The decoder device ("dec-dev") should be tied to the lifecyle of an 
> enabled window.
> 
>> And AFAIK, the vout should not know about the decoder or decoder 
>> device at
>> all. It should use the video context only.
> 
> And how do you plan to convey this decoder device instance to the 
> decoder/filters without going through the vout ?

For the record, the decoder device is created with a vout_window_t, 
because in some cases (VAAPI for example) it needs to know about which 
window is used. This vout_window_t is created and stored by the vout.