[vlc-devel] [PATCH 1/2] rtsp: ensure session ID is at least 8 bytes

Alexandre Janniaux ajanni at videolabs.io
Mon Sep 23 13:08:43 CEST 2019


Ok, I agree with you,

Please discard the first patch and only consider the second one, which
is fixing a warning.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Sep 12, 2019 at 09:48:51PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 12. syyskuuta 2019, 21.35.33 EEST Alexandre Janniaux a écrit :
> > The associated RFC declares that it would need at least 8 bytes of data for
> > a session id.
>
> 8 bytes of non-guessable random data. The patch fixes nothing. The value still
> has 32-bits, and still is guessable.
>
> And still, I don't see what session ID has to do with RTP. The closest RTP has
> to a session ID are SSRC & CSRC, which have 32 bits.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list